C++: Make 'getChildCount' more robust by counting indices instead of elements #21280
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'TranslatedDeclarationEntry's.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a robustness issue in the C++ IR (Intermediate Representation) implementation where inconsistent databases could cause the control-flow graph to abruptly stop. The fix changes how getChildCount() calculates the number of children in declaration statements.
Changes:
- Modified
TranslatedDeclStmt.getChildCount()to count distinct indices instead of counting elements, preventing issues when duplicate elements exist for a single index on inconsistent databases.
IdrissRio
approved these changes
Feb 6, 2026
Contributor
IdrissRio
left a comment
IdrissRio
left a comment
There was a problem hiding this comment.
LGTM 👍
DCA looks good as well except for one project failing with: fatal error occurred: Injecting Windows tracer failed which is completely unrelated.
Contributor
Author
|
Thanks, Idriss! DCA looks fantastic. A not insignificant reduction in dead ends in the CFG across all projects. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an ideal world counting elements should give the same as counting how many indices returns an element. However I noticed today that, on inconsistent databases, it is possible that a single index can return duplicated
getDeclarationEntrys.This meant that
getChildCount()returned 2 (because there were twogetDeclarationEntrys for index0). However, onlygetDeclarationEntry(0)had a result (in fact it had 2 results), andgetDeclarationEntry(1)returned no results. This caused the control-flow graph abruptly stop.By changing
getChildCountto count indices instead we avoid a dead-end in the control-flow graph sincegetChildCount()now returns 1.